Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(filter): clarify what filter matches against #8750

Closed
wants to merge 1 commit into from

Conversation

patelvin
Copy link

No description provided.

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@patelvin
Copy link
Author

I've just signed up CLA with email vinp.developer@gmail.com - this is not a primary email for my GitHub account and hope that's not a problem.

@caitp
Copy link
Contributor

caitp commented Aug 25, 2014

Patch was authored with bhavin.patel@cengage.com --- you'll need to amend the commit with git commit --amend --author="patelvin <vinp.developer@gmail.com>" and force-push for MP to recognize it

@caitp
Copy link
Contributor

caitp commented Aug 25, 2014

But, you don't need a CLA for docs anyways, so no biggy =p

@btford btford added this to the Backlog milestone Sep 3, 2014
@btford
Copy link
Contributor

btford commented Sep 3, 2014

I agree the explanation for filters could be improved, but I think the explanation in this change is too terse.

@Narretz
Copy link
Contributor

Narretz commented Jun 5, 2015

Closing because there has been no activity (and the CLA is missing)

@Narretz Narretz closed this Jun 5, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants